PolymerElements / app-route

A modular client-side router
https://www.polymer-project.org/1.0/articles/routing.html
146 stars 66 forks source link

Fix of props update order, inactive while updating if data changed #222

Closed iSuslov closed 6 years ago

iSuslov commented 6 years ago

148

185

148

164

Please see https://github.com/PolymerElements/app-route/issues/164#issuecomment-366106287

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


googlebot commented 6 years ago

CLAs look good, thanks!

iSuslov commented 6 years ago

Hi, your idea is reasonable and I will try it. I made another commit, which probably will fail unit testing again, the idea is to set app-route to inactive state while updating properties if data changed and then bring it back to active. Why it is important: see updated https://github.com/PolymerElements/app-route/issues/164#issuecomment-366106287

iSuslov commented 6 years ago

Well, using internals of 'setProperties' does not help really, since it is still unordered on lower level https://github.com/Polymer/polymer/blob/5c02730974f8e3138405e596cb5f8d8bb388a41f/lib/mixins/property-effects.html#L124

e111077 commented 6 years ago

Any updates?

mercmobily commented 6 years ago

Ho there. I am following this issue from #164 which is still basically unresolved... and it looks like it will be for a while. Any hints on this?