Closed SergeShkurko closed 6 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
I signed it!
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.
CLAs look good, thanks!
This is a simple solution to a common problem, but the issue is that this is a breaking change. would it be possible to put this behind a flag and also write a test for it?
@e111077 Change is not critical. Tests added
@e111077 edits made
@e111077 Fixed
Very well done, thanks for the PR
Added default path ("/"). It resolve problem with subroute data change (#224 )
Before "Nested component" inactive, already - active
For example: url: 'localhost:8080/foo'
Before:
After