search

PolymerElements / app-storage

Data-pipes and specialized services
61 stars 47 forks source link

Follow-up on #72 #115

Closed mkazlauskas closed 6 years ago

mkazlauskas commented 7 years ago

@e111077

Did a rebase on #72

Haven't found time to rework the tests yet, so excluded them from this PR for now.

Let me know if you need anything else.

Thanks

e111077 commented 6 years ago

Any updates on tests?

mkazlauskas commented 6 years ago

Added tests for my fixes

googlebot commented 6 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.