search

PolymerElements / app-storage

Data-pipes and specialized services
61 stars 47 forks source link

Replace arguments with ...args #130

Closed aomarks closed 6 years ago

aomarks commented 6 years ago

This makes the _log and _error type signatures match the ones in LegacyElementMixin. Will help TypeScript typings match up.

https://github.com/Polymer/polymer/blob/master/lib/legacy/legacy-element-mixin.js#L946

e111077 commented 6 years ago

Travis is on the fritz again. Doing a rerun

aomarks commented 6 years ago

Travis is on the fritz again. Doing a rerun

It looks like there is an actual test failure along with how Safari is always broken, but pretty sure it's not related to this CL.

Windows 8.1 IE 11 ✖ test/app-localstorage/app-localstorage-document.html » storage key change » reinitializes stored value regardless of previous initialization success

e111077 commented 6 years ago

ah I think this was that issue regarding the polymer labs promise polyfill vs the one in the webcomponents polyfill, but yeah, unrelated to this PR.