search

PolymerElements / app-storage

Data-pipes and specialized services
61 stars 47 forks source link

Convert CommonWorker and AppIndexedDBMirrorClient to ES6 classes. #131

Closed aomarks closed 6 years ago

aomarks commented 6 years ago

This helps Analyzer understand them, for type generation.

e111077 commented 6 years ago

Still looks like there's something weird going on

aomarks commented 6 years ago

Still looks like there's something weird going on

Oops, had a brace in the wrong place, passing now.

bicknellr commented 6 years ago

There was still an IE11 test failing there. Could you check that out?

aomarks commented 6 years ago

There was still an IE11 test failing there. Could you check that out?

Looking

e111077 commented 6 years ago

Sure it's unrelated to this PR but I'll take a look tomorrow

aomarks commented 6 years ago

Sure it's unrelated to this PR but I'll take a look tomorrow

Yeah it looks like a flaky test that has been failing already, e.g. same error at f67cc27d32a5938fe1aaaece2b0247811e1138ad: https://travis-ci.org/PolymerElements/app-storage/builds/413726089?utm_source=github_status&utm_medium=notification

bicknellr commented 6 years ago

Yeah, looks like this is pretty old. (Within the 3.0 updates, that is.)

e111077 commented 6 years ago

Looked into it. I patched over the master (unpublished) version of webcomponentsjs' promise polyfill and it seems to fix the issue. ETA from dan is today or this monday