search

PolymerElements / app-storage

Data-pipes and specialized services
61 stars 47 forks source link

Fix for cross-origin frame issue where page is hosted in iframe #141

Closed socsieng closed 4 years ago

socsieng commented 4 years ago

Fixes #97

This fix prevents accessing window.top when the current window and window.top do not share the same origin.

e111077 commented 4 years ago

running internal tests

e111077 commented 4 years ago

I don't see the build issues you speak of. Can you explain a bit further?

socsieng commented 4 years ago

It was a stupid error on my part. I had an assignment instead of an equality check which cause the page to continuously reload. I fixed the pull request. All good now.

On Thu, Jan 30, 2020 at 2:22 PM Elliott Marquez notifications@github.com wrote:

I don't see the build issues you speak of. Can you explain a bit further?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PolymerElements/app-storage/pull/141?email_source=notifications&email_token=AAUGIFUOHBTK2YY7LKTRTULRANHJHA5CNFSM4KNAHVQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKMZFDQ#issuecomment-580489870, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUGIFVG3DCXWABV5BV44BDRANHJHANCNFSM4KNAHVQQ .

socsieng commented 4 years ago

Is there an ETA on when it might be released?

e111077 commented 4 years ago

Passed internal eval. Releasing

e111077 commented 4 years ago

released