PolymerElements / app-storage

Data-pipes and specialized services
61 stars 47 forks source link

app-network-status-behavior:refreshNetworkStatus trying to set readonly property: online. #58

Open dmix007 opened 8 years ago

dmix007 commented 8 years ago

Description

app-storage is trying to the a read-only property. Results in a console error at load time using Polymer^1.6.

Console Error: Uncaught TypeError: this._setOnline is not a function Source & Line #: app-network-status-behavior:68

More Detail: Uncaught TypeError: this._setOnline is not a functionrefreshNetworkStatus @ app-network-status-behavior.html:68attached @ app-network-status-behavior.html:53_invokeBehavior @ polymer-micro.html:434_doBehavior @ polymer-micro.html:427(anonymous function) @ polymer-micro.html:211_makeReady @ polymer-micro.html:109(anonymous function) @ polymer-micro.html:115

Expected outcome

No console errors or warnings.

Actual outcome

Console warning about there not being a setter for a read-only variable (online).

Live Demo

N/A

Steps to reproduce

Browsers Affected

fairsayan commented 7 years ago

Temporary solution at https://github.com/fairsayan/app-storage waiting for the fix. I just removed the readOnly attribute from online property and set directly. Install: bower install https://github.com/fairsayan/app-storage.git#03c3b72131fddacc00dc2cf9c4fc32e401370e5d --save

PS: to me wasn't just a warn, it was an error that broke the js flow.

arkihillel commented 7 years ago

Still broken

Thanks for the link to the working version fairsayan, works as expected