Reducing .icon-container height from 27 to 24px

aengusbates commented 8 years ago

The .icon-container height style is causing gold-cc-input to display inconsistently with the other input fields of the PolymerElements project. Simple fix.

Please see screen grabs of bug and fix states with chrome dev console open. https://drive.google.com/folderview?id=0B_0yM-1o-T_jMm9nTG5RWHF0Vmc&usp=sharing

I haven't opened an Issue to track for this bug. I can if needed.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

aengusbates commented 8 years ago

I signed it!

On Fri, Feb 5, 2016 at 1:27 PM, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

[image: :memo:] Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.

If you signed the CLA as a corporation, please let us know the company's name.

— Reply to this email directly or view it on GitHub https://github.com/PolymerElements/gold-cc-input/pull/43#issuecomment-180561433 .

googlebot commented 8 years ago

CLAs look good, thanks!

aengusbates commented 8 years ago

Failing test don't look related to this change. Failing on Chrome, but not Firefox. Any suggestions?

notwaldorf commented 8 years ago

The tests are broken in master as well, it's not your change :)

PolymerElements / gold-cc-input

Reducing .icon-container height from 27 to 24px #43

verify. Thanks.