PolymerElements / gold-cc-input

An input element that only allows credit card numbers
https://webcomponents.org/element/PolymerElements/gold-cc-input
13 stars 23 forks source link

fixed issue #56 - invalid property does not update #57

Open ahmedelkilani opened 7 years ago

ahmedelkilani commented 7 years ago

Fixed issue #56 . invalid property is not updated even after calling validate method.

mcrowder65 commented 7 years ago

Could we get this merged?

TomK commented 7 years ago

Potentially this is not the correct approach. IronValidatableBehavior states custom validation should override the method _getValidity and not validate.

Both these solutions fix the issue, but potentially overriding _getValidity is more correct based on documentation.

@arthurevans @e111077 can one of you point this in the right direction?

e111077 commented 7 years ago

requesting the summon of the queen of inputs and validation @notwaldorf

notwaldorf commented 7 years ago

It seems in other elements we do both? https://github.com/PolymerElements/gold-cc-cvc-input/blob/master/gold-cc-cvc-input.html#L313