Closed cherukumilli closed 8 years ago
Hi! Thanks for pointing this out! Would you be interested in sending a PR for that? 😻
@notwaldorf I think #52 needs to be fixed before fixing #51. If you think the solution to #52 is acceptable then I will submit PR's for each of them separately.
Sounds good!
@cherukumilli are you still interested in sending a PR for this?
@notwaldorf - Yes. I will submit the pull request tomorrow morning.
gold-phone-input's code is not following the same standards as other elements. gold-phone-input's javascript code is outside the . All other elements have javascript code inside the tags
Current gold-phone-input code:
Expected:
A similar issue has been fixed for other elements like paper-fab. Please check https://github.com/PolymerElements/paper-fab/pull/53 for details.