PolymerElements / gold-phone-input

An input element that only allows phone numbers
https://webcomponents.org/element/PolymerElements/gold-phone-input
13 stars 30 forks source link

Move <script> inside <dom-module> #51

Closed cherukumilli closed 8 years ago

cherukumilli commented 8 years ago

gold-phone-input's code is not following the same standards as other elements. gold-phone-input's javascript code is outside the . All other elements have javascript code inside the tags

Current gold-phone-input code:

...
<dom-module>
   ...
</dom-module>
<script>
   ...
</script>

Expected:

...
<dom-module>
   ...
   <script>
      ...
   </script>
</dom-module>

A similar issue has been fixed for other elements like paper-fab. Please check https://github.com/PolymerElements/paper-fab/pull/53 for details.

notwaldorf commented 8 years ago

Hi! Thanks for pointing this out! Would you be interested in sending a PR for that? 😻

cherukumilli commented 8 years ago

@notwaldorf I think #52 needs to be fixed before fixing #51. If you think the solution to #52 is acceptable then I will submit PR's for each of them separately.

notwaldorf commented 8 years ago

Sounds good!

notwaldorf commented 8 years ago

@cherukumilli are you still interested in sending a PR for this?

cherukumilli commented 8 years ago

@notwaldorf - Yes. I will submit the pull request tomorrow morning.