fix caret magic and add a bunch of tests to prove it

PolymerElements / gold-phone-input

An input element that only allows phone numbers

13 stars 30 forks source link

Closed notwaldorf closed 8 years ago

notwaldorf commented 8 years ago

Basically, the caret magic math was wrong. The TLDR of the logic is:

count how many - you had initially before the cursor
since you've already typed, the browser has already advanced the cursor correctly (ignoring the formatting)
after you redo the formatting, count how many - you have now before the cursor
whatever the difference is, update the cursor!

bicknellr commented 8 years ago

LGTM

notwaldorf commented 8 years ago

Yay! Thanks!