search

PolymerElements / gold-phone-input

An input element that only allows phone numbers
https://webcomponents.org/element/PolymerElements/gold-phone-input
13 stars 30 forks source link

Tell the compiler the type of `value` #59

Closed rictic closed 8 years ago

notwaldorf commented 8 years ago

LGTM

notwaldorf commented 8 years ago

Wait, why are all of these needed? value comes from PaperInputBehavior, which has a type :(

rictic commented 8 years ago

The PolymerPass as currently written wants to know whether we're reassigning the type

rictic commented 8 years ago

It would be nice to make it smarter, but this is quick and easy for now

notwaldorf commented 8 years ago

Got it! Still LGTM

rictic commented 8 years ago

Thanks!