PolymerElements / gold-phone-input

An input element that only allows phone numbers
https://webcomponents.org/element/PolymerElements/gold-phone-input
13 stars 30 forks source link

fix(binding): fix international value binding #93

Closed masonlouchart closed 6 years ago

masonlouchart commented 6 years ago

Before this commit, the property internationalValue was only one-way binding. Others elements watching this value were not aware of the changes. Now the gold-element-input is using two-way binding on this property so parents are notified about the changes.

Fixes #83

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


googlebot commented 6 years ago

CLAs look good, thanks!

masonlouchart commented 6 years ago

I signed it! (and rewrote the commit with proper email address).

masonlouchart commented 6 years ago

With the notify attribute:

gold-phone-input-international-value