search

PolymerElements / iron-a11y-keys-behavior

A behavior that enables keybindings for greater a11y
24 stars 41 forks source link

prefer key to deprecated keyIdentifier and keyCode #57

Closed valdrinkoshi closed 8 years ago

valdrinkoshi commented 8 years ago

Fixes #53, if key is defined in the event or artificially generated event (detail.key), we prefer that over keyIdentifier or keyCode. I've updated the test to actually check for the result of shift + ctrl + a which gives event.key = 'A', and purposely removed keyCode, code settings to mimic the ideal, future keyboard event which will have only key set.

valdrinkoshi commented 8 years ago

@cdata @samccone FYI, PTAL

samccone commented 8 years ago

LGTM