search

PolymerElements / iron-a11y-keys

A basic element implementation of iron-a11y-keys-behavior
19 stars 22 forks source link

Docs: Add 'meta' as one of the potential modifier keys #21

Closed miztroh-zz closed 8 years ago

notwaldorf commented 8 years ago

I think you're looking for meta: http://jsbin.com/lohesa/edit?html,output

miztroh-zz commented 8 years ago

@notwaldorf That's how I normally refer to it as well, but I couldn't find any mention of meta in the docs: https://elements.polymer-project.org/elements/iron-a11y-keys

miztroh-zz commented 8 years ago

@notwaldorf In fact, the docs explicitly say "The modifier keys are: Shift, Control, Alt."

notwaldorf commented 8 years ago

Ah yes, that sounds like a documentation bug. Re-opening and re-titling :)

Would you be interested in sending a patch to fix that?

miztroh-zz commented 8 years ago

@notwaldorf No problem: https://github.com/PolymerElements/iron-a11y-keys/pull/22

jarrodek commented 8 years ago

The docs are still showing docs without the PR even if the PR was already merged with master.