Closed jpodwys closed 8 years ago
@rictic Given our conversation in #191 about how the error
event cannot pierce the shadow dom, I'd really appreciate the team reconsidering merging this in 1.x
.
Can someone please provide an update on this?
@rictic @cdata I'd really appreciate some feedback on this. It's been a month and a half since I submitted the PR and I've provided valid data for why it's more important than the iron-ajax team originally thought (see the conversation in #191).
@cdata @rictic @notwaldorf Is this repository still maintained? I submitted this PR three months ago and have still not received a response from a maintainer. I would really appreciate some feedback as multiple people have asked for something along these lines. I have been using my fork of iron-ajax in production for over two months now because iron-ajax no longer meets my needs. I would love to get back onto master if possible.
@jpodwys It's still maintained! Sorry about this -- I think it fell off everyone's radar. Hopefully @e111077 can take a look at this soon :)
@e111077 Let me know if you think we should merge this, or wait until the 2.0 release and deprecate the old names, and/or both. If we're going the "deprecate the old names" path, can you please open an issue for that? Thanks!
Thank you, I'm excited for a response on this!
@notwaldorf PR is pretty solid, backwards-compatible, and fairly-inexpensive. Hopefully this can be solved in a more DRY approach in 2.0; Peter has dropped some solid 2.0 solutions which are worth considering, but this is an appropriate fix for now.
Thanks a lot for the submissions and for holding in there @jpodwys! Solid PRs! :beers:
Thanks for the feedback! I hope to update the PR this week.
PR should be ready now
iron-ajax-<event-type>
events fire regardless of this.bubbles
valuethis.bubbles
to detail the change as well as why the error
event never bubbles (please indicate if my explanation needs to be changed)@notwaldorf @rictic @e111077
LGTM! thanks for the PR!
Awesome, thank you! If you don't mind, I'd really appreciate a new release.
Haha thanks for the fast work!
Makes it so that when
bubbles
is used,iron-ajax-request
,iron-ajax-response
, andiron-ajax-error
events will bubble towindow
while the usual scopedrequest
,response
, anderror
events are still fired.This is necessary because it seems there is no way to get the
error
event to escape the shadow dom.Should fix #134.