PolymerElements / iron-ajax

Easily make ajax requests
https://www.webcomponents.org/element/PolymerElements/iron-ajax
127 stars 113 forks source link

Addressing scoped event naming with backwards compatibility #194

Closed jpodwys closed 8 years ago

jpodwys commented 8 years ago

Makes it so that when bubbles is used, iron-ajax-request, iron-ajax-response, and iron-ajax-error events will bubble to window while the usual scoped request, response, and error events are still fired.

This is necessary because it seems there is no way to get the error event to escape the shadow dom.

Should fix #134.

jpodwys commented 8 years ago

@rictic Given our conversation in #191 about how the error event cannot pierce the shadow dom, I'd really appreciate the team reconsidering merging this in 1.x.

jpodwys commented 8 years ago

Can someone please provide an update on this?

jpodwys commented 8 years ago

@rictic @cdata I'd really appreciate some feedback on this. It's been a month and a half since I submitted the PR and I've provided valid data for why it's more important than the iron-ajax team originally thought (see the conversation in #191).

jpodwys commented 8 years ago

@cdata @rictic @notwaldorf Is this repository still maintained? I submitted this PR three months ago and have still not received a response from a maintainer. I would really appreciate some feedback as multiple people have asked for something along these lines. I have been using my fork of iron-ajax in production for over two months now because iron-ajax no longer meets my needs. I would love to get back onto master if possible.

notwaldorf commented 8 years ago

@jpodwys It's still maintained! Sorry about this -- I think it fell off everyone's radar. Hopefully @e111077 can take a look at this soon :)

@e111077 Let me know if you think we should merge this, or wait until the 2.0 release and deprecate the old names, and/or both. If we're going the "deprecate the old names" path, can you please open an issue for that? Thanks!

jpodwys commented 8 years ago

Thank you, I'm excited for a response on this!

e111077 commented 8 years ago

@notwaldorf PR is pretty solid, backwards-compatible, and fairly-inexpensive. Hopefully this can be solved in a more DRY approach in 2.0; Peter has dropped some solid 2.0 solutions which are worth considering, but this is an appropriate fix for now.

Thanks a lot for the submissions and for holding in there @jpodwys! Solid PRs! :beers:

jpodwys commented 8 years ago

Thanks for the feedback! I hope to update the PR this week.

jpodwys commented 8 years ago

PR should be ready now

@notwaldorf @rictic @e111077

e111077 commented 8 years ago

LGTM! thanks for the PR!

jpodwys commented 8 years ago

Awesome, thank you! If you don't mind, I'd really appreciate a new release.

e111077 commented 8 years ago

Already released as 1.4.0

jpodwys commented 8 years ago

Haha thanks for the fast work!