PolymerElements / iron-ajax

Easily make ajax requests
https://www.webcomponents.org/element/PolymerElements/iron-ajax
127 stars 113 forks source link

exposes progress of iron-ajax.lastRequest #228

Closed e111077 closed 6 years ago

e111077 commented 8 years ago

Fixes #34. Seems like an issue lost in space @rictic

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


googlebot commented 8 years ago

CLAs look good, thanks!

e111077 commented 8 years ago

@rictic The tests seem to be a failure with Firefox; I don't see these locally. Is this an issue with FF in travis, or is this a real problem?

rictic commented 8 years ago

Unsure about the travis errors, check with Dan while I'm out if town. I think last-progress would be a better name for this.

I'd also like to see a test here.

e111077 commented 8 years ago

@cdata only fails because of FF error now. Fixed IE issues.

olivierlangelaar commented 8 years ago

What does this need?

MajorBreakfast commented 7 years ago

Sounds interesting! I could make use of this in my app

ArthurJahn commented 7 years ago

Any progress on this?

e111077 commented 7 years ago

Slipped through the cracks during Polymer 2 development

e111077 commented 7 years ago

~There seems to be a regression in Polymer 2.0 see: Polymer/polymer#4624~ This is caused by a webcomponents v0 -> v1 spec.

or9 commented 6 years ago

Where is this?

e111077 commented 6 years ago

@valdrinkoshi implemented suggestion and added test

e111077 commented 6 years ago

Apparently the tests were wrong. Thanks for the suggestion