search

PolymerElements / iron-autogrow-textarea

Textarea that grows in height as more lines of input are entered
https://webcomponents.org/element/PolymerElements/iron-autogrow-textarea
19 stars 48 forks source link

fix: on-change event in shadowRoot #122

Closed AliMD closed 1 year ago

AliMD commented 6 years ago

As you know, In the Shadow DOM, the change event is not leaked into the ancestor tree, so we must do this manually. This is done in the rest of the input components by paper-input-behavior.

Fixed https://github.com/PolymerElements/paper-input/issues/664

AliMD commented 6 years ago

@notwaldorf We have an issue in our app and need to fix it as soon as possible Could you please review/merge this PR with priority Thank you in advance.

AliMD commented 6 years ago

travis error is not related to this PR changes!

notwaldorf commented 6 years ago

The travis error is actually related to this PR: it says `Typings are stale. Please run "npm run update-types". You've added a new event type, which needs to be typed :)

Please update the types, then this should be good to merge

AliMD commented 6 years ago

@notwaldorf Oops! Excuse me.

AliMD commented 6 years ago

Why issue remains?!

AliMD commented 6 years ago

@notwaldorf I fix the generated declaration manually, but could you please check this issue for future PR?

My generated declaration interface IronAutogrowTextareaElement extends Polymer.IronValidatableBehavior, Polymer.IronControlState, Polymer.LegacyElementMixin, HTMLElement {

Travise interface IronAutogrowTextareaElement extends Polymer.Element, Polymer.IronValidatableBehavior, Polymer.IronControlState {

https://travis-ci.org/PolymerElements/iron-autogrow-textarea/builds/413055027?utm_source=github_status&utm_medium=notification

notwaldorf commented 6 years ago

cc @bicknellr for a release