master branch is hard-coded - Githubissues

PolymerElements / iron-component-page

A reusable landing page for elements

36 stars 32 forks source link

master branch is hard-coded #101

Open tomalec opened 8 years ago

tomalec commented 8 years ago

Description

iron-component-page has "master" branch name hard-coded therefore it's impossible to use it with any other branch.

Expected outcome

iron-component-page should be able to render component page regardless of branch name

Actual outcome

No documentation found.

is shown

Live Demo

http://puppetjs.github.io/puppet-polymer-client/

Steps to reproduce

Create custom-element as any other.
Use branch anything.
Open http://yourorganization.github.io/custom-element/.
Browsers Affected

[x] Chrome
[x] Firefox
[x] Safari 9
[x] Safari 8
[x] Safari 7
[x] Edge
[x] IE 11
[x] IE 10

tomalec commented 8 years ago

@justinfagnani Could you take a look? All checks are passing for PR https://github.com/PolymerElements/iron-component-page/pull/102. I think the fix is quite non-intrusive. But issue makes iron-component-page useless to quite many (at least our) custom elements.