PolymerElements / iron-component-page

A reusable landing page for elements
36 stars 32 forks source link

Add `noRewrite` option to allow prevention of gh-pages URL rewrites. #45

Closed devinivy closed 8 years ago

devinivy commented 9 years ago

Resolves #44.

googlebot commented 9 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


devinivy commented 9 years ago

I signed it!

googlebot commented 9 years ago

CLAs look good, thanks!

blasten commented 8 years ago

I'm a little hesitant about this option. It might make sense to expose the branch name as a property instead. I will close this PR for now and let's continue the discussion in #44 as we plan to rewrite this element at some point.