search

PolymerElements / iron-component-page

A reusable landing page for elements
36 stars 32 forks source link

polybuild failing when page is including iron-component-page #81

Closed purdrew closed 8 years ago

purdrew commented 8 years ago

I've ran into an issue with the 1.1.3 release of iron-component-page that is causing the polybuild of my project to fail with an error like this:

[15:59:44] Error in plugin "polyclean"
Message:
    Line 257: Unexpected token (
Details:
    index: 7362
    lineNumber: 257
    column: 27
    description: Unexpected token (

I've tracked it down to this change in commit 37481d3defd132b194e7ff68d87dab7c54b7c2dd made in PR #76 . Not sure if it was intentional or not, but looks like an ES2015 method definition is being used. Uglifyjs apparently does not support ES2015 yet. Simple fix would be to define the method without using ES2015 method definition.

_setActiveFromHash: function(hash) {
notwaldorf commented 8 years ago

Would you be interested in sending a PR to fix it? I think you're right, and it should indeed be setActiveFromHash: function(hash).

purdrew commented 8 years ago

It was fixed by #82. This can be closed.

notwaldorf commented 8 years ago

Yay, thanks!