Rewrite _setActiveFromHash method definition to work with Safari 8

armyofgnomes commented 8 years ago

The current way it's written breaks in Safari 8.0.6

I didn't open a specific issue for this because it's such a small change.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

armyofgnomes commented 8 years ago

I signed it!

googlebot commented 8 years ago

CLAs look good, thanks!

purdrew commented 8 years ago

This fixes the issue reported in issue #81.

arthurevans commented 8 years ago

LGTM. Thanks for the fix.

@blasten, I don't have Safari 8 available to repro the bug, but it's pretty clear this was a typo on my part and the fix is correct. Tested locally & works fine. If I merge, could you cut a new release?

blasten commented 8 years ago

Thanks for the fix!

PolymerElements / iron-component-page

Rewrite _setActiveFromHash method definition to work with Safari 8 #82