PolymerElements / iron-component-page

A reusable landing page for elements
36 stars 32 forks source link

Load transitive behaviors but only display the current folder #86

Closed garlicnation closed 7 years ago

garlicnation commented 8 years ago

Fixes #39

blasten commented 8 years ago

btw, @justinfagnani is taking over the maintenance of iron-component-page.

justinfagnani commented 8 years ago

LGTM

justinfagnani commented 8 years ago

Upon further discussion with @notwaldorf, let's make sure that a failure to load a dependency doesn't kill the whole page.

justinfagnani commented 8 years ago

for proper linking, this fixes #39

justinfagnani commented 8 years ago

@garlicnation ping. where are we at with this?

garlicnation commented 8 years ago

@justinfagnani blocked on https://github.com/Polymer/hydrolysis/pull/217

That PR will avoid no elements being displayed in the case where bower_components is missing.

We should look into displaying a notification that dependencies are missing.

TimvdLippe commented 8 years ago

https://github.com/Polymer/hydrolysis/pull/217 has been merged.

I have tested this branch and it correctly shows properties, methods and events. The button is also clickable, you see the documentation of the behavior. The only thing that did not work is that when you click the button, the name on the top-left (the drop-down to select the different packaged behaviors) remains empty. For me the two behaviors I use in my elements are not added to the dropdown.

http://timvdlippe.github.io/iron-lazy-pages/components/iron-lazy-pages/ was used to test the behavior. (You might need to clear cache and hard reload if you visited this page before)

garlicnation commented 8 years ago

@justinfagnani PTAL

venicia commented 8 years ago

@justinfagnani Any chance this will be merged to master this week? We need this ASAP.

aomarks commented 7 years ago

Closing this PR. The 3.0 RC is now available and uses Analyzer instead of Hydrolysis, and shows properties inherited from behaviors/mixins.