search

PolymerElements / iron-component-page

A reusable landing page for elements
36 stars 32 forks source link

window.console -> Polymer.Base #95

Closed valdrinkoshi closed 7 years ago

valdrinkoshi commented 8 years ago

Merge after https://github.com/Polymer/polymer/issues/3574 gets fixed.

abdonrd commented 8 years ago

@valdrinkoshi you link an issue, not a PR. :)

valdrinkoshi commented 8 years ago

@abdonrd I linked the issue that needs to be fixed before this PR can be merged. No PR is available for that issue yet.

abdonrd commented 8 years ago

@valdrinkoshi ah, okey! Thanks! :)

notwaldorf commented 8 years ago

LGTM

justinfagnani commented 8 years ago

Won't we need an associated version constraint bump for the polymer dep?

valdrinkoshi commented 8 years ago

You're right @justinfagnani, I'll wait for it to be published & will update all these PRs

justinfagnani commented 8 years ago

btw, what is the advantage of using Polymer's logging over console?

valdrinkoshi commented 8 years ago

@justinfagnani, updated the version constraint, PTAL

aomarks commented 7 years ago

Closing this PR as development has moved to the 3.0 Analyzer version (on master and RC).

Still curious to hear why we might want to use Polymer's logging over console?

valdrinkoshi commented 7 years ago

@aomarks the request comes from the need to have a way to silence logs/warnings/errors by overriding Polymer's methods.

aomarks commented 7 years ago

@valdrinkoshi Why do we want to do that?

valdrinkoshi commented 7 years ago

Some Polymer users relied on these protected methods to disable warnings or logs coming from certain components. Polymer.Base was already exposing these, but not many PolymerElements were actually using those.