Closed mrdevin closed 6 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
CLAs look good, thanks!
Sorry for the extremely delayed review.
I tried out this PR, and I found it confusing that when a method was both inherited and protected, you need to click both hide bars. I couldn't immediately think of a way to make that more intuitive.
I am wondering if we need a larger reorganization, where each inherited class's methods and properties is shown in its own section, and is collapsed by default.
no stress.
I think your idea to reorganize makes more sense then what i proposed. IF i get time I might make an attempt to reorganize myself but then on another branch.
thanks!
Fixes #163
when building polymer elements that extend Polymer.Element it can be hard to find your own methods in the long list of inherited methods. This solution has all inherited methods hidden by default and adds an iron-doc-hide-bar to toggle inherited methods.
It would be great if we could have something like this. Any improvements or suggestions.