PolymerElements / iron-elements

Core elements
47 stars 23 forks source link

Make it easier to vulcanize all iron elements #20

Closed krainboltgreene closed 9 years ago

krainboltgreene commented 9 years ago

This gives an easy entrypoint for pulling in all iron element components, both in the regular import way and as a vulcanize target.

googlebot commented 9 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


krainboltgreene commented 9 years ago

I signed it!

googlebot commented 9 years ago

CLAs look good, thanks!

adalinesimonian commented 9 years ago

+1 - though I would consider naming it something less vulcanize-specific, such as iron-elements.html, because that would be less odd of a usage for the use-case described in http://stackoverflow.com/questions/30652584/polymer-1-0-import-all-elements-at-once

Perhaps I am a little biased. :wink:

krainboltgreene commented 9 years ago

@vsimonian I agree! *-elements.html makes a lot more sense.

ebidel commented 9 years ago
  1. bower_components shouldn't be in the path. The paths should take the form https://github.com/Polymer/core-elements/blob/master/core-elements.html
  2. +to usingiron-elements.html`

TBH, I'm not sure why we don't have these aggregated imports in iron-elements and paper-elements. I think one issue may be that we still see people importing a lot more elements than they need. Not having these aggregated imports prevents people from going down that road.

adalinesimonian commented 9 years ago

I think the issue isn't so much for deployment as much as for rapid prototyping. I can definitely attest to having saved a lot of time just importing everything and playing with it, and then picking out what elements I need and explicitly importing them once I'm satisfied with my prototype. It becomes tedious to manage a list of imports when you're experimenting or testing things out.

cdata commented 9 years ago

I'm closing this for now. Please re-open if you think this should be considered again!