search

PolymerElements / iron-fit-behavior

Fits an element into another element
17 stars 34 forks source link

Positioning & overlapping #38

Closed valdrinkoshi closed 8 years ago

valdrinkoshi commented 8 years ago

Fixes #36, fixes #37

valdrinkoshi commented 8 years ago

When I manually launch the tests on sauce labs they pass both on chrome and firefox: https://saucelabs.com/beta/tests/bf660e28b5644fefa1fd4fdce70e82c6/watch https://saucelabs.com/beta/tests/82f0385a6066483a9837da984ffc7679/watch https://saucelabs.com/beta/tests/e670d6ac6d804e94a13b71ce7d64bc9c/watch Same when i run them locally.

@azakus can you please have a look?

valdrinkoshi commented 8 years ago

@cdata here the feature you asked, PTAL :)

cdata commented 8 years ago

:beers:

cdata commented 8 years ago

Dare I ask what is wrong with the test suite?

valdrinkoshi commented 8 years ago

@cdata feedback incorporated. About the tests, as mentioned before they result all green when i run them manually (both on local and in saucelabs). @azakus any clue on this one?

cdata commented 8 years ago

LGTM 👍 awesome work on this! ✨