search

PolymerElements / iron-fit-behavior

Fits an element into another element
17 stars 34 forks source link

2.0 preview #64

Closed valdrinkoshi closed 7 years ago

valdrinkoshi commented 8 years ago

I adapted it to work both in 1.0 and 2.0.

googlebot commented 7 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot commented 7 years ago

CLAs look good, thanks!

bicknellr commented 7 years ago

The demo seems broken: nothing happens when I click on any of the buttons or the boxes labelled 'target'.

valdrinkoshi commented 7 years ago

@bicknellr re nothing happening on click => https://github.com/Polymer/polymer/issues/4509

googlebot commented 7 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

valdrinkoshi commented 7 years ago

Wow good catch! 💯 Yeah it looks like a dom-bind bug...please update this PR with the issue! In case that's a "wontfix" from dom-bind, it would be still useful to have a pointer to that in a comment 👌

bicknellr commented 7 years ago

Filed as Polymer/polymer#4536; sounds like they're planning on fixing this today.

bicknellr commented 7 years ago

^ Update on this bug: merged, so should be in v1.9.1.

bicknellr commented 7 years ago

... and we're tagged. I'll give the demos another quick check.

googlebot commented 7 years ago

CLAs look good, thanks!