Open joshuahiggins opened 6 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed the CLA.
This PR is one solution for addressing #81. Here is a gif showing it in action:
CLAs look good, thanks!
Any thoughts on how to resolve? It looks like everything passes.
(edited by bicknellr so that this doesn't take up a mile of screen :)
LGTM for modulizer side of this PR for me. Pending review from Valdrin
@valdrinkoshi Apologies for the delayed response to your review. I somehow missed the notification. Great suggestions! I implemented both.
This approach creates an element on the fly to determine scrollbar sizing at the moment of the resize. This allows it to work with browser zooming which, while visually the same to the end user, will result in different measurements.
When a scrollbar is needed, the overall
maxWidth
ormaxHeight
is increased by the size of the scrollbar.