PolymerElements / iron-fit-behavior

Fits an element into another element
17 stars 34 forks source link

add a status 'undefined' for horizontalAlign and verticalAlign #97

Open hzmsrv opened 5 years ago

hzmsrv commented 5 years ago

sometimes we only need the element to drop down without any style like top, width, height...

the default will change those styles directly on the element. it is top level and change in runtime.

so we add this undefined to stop changing.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
hzmsrv commented 5 years ago

I signed it! ᐧ

googlebot notifications@github.com 于2018年11月2日周五 下午3:31写道:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA Individual signers

Corporate signers

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PolymerElements/iron-fit-behavior/pull/97#issuecomment-435294856, or mute the thread https://github.com/notifications/unsubscribe-auth/AFHQVmqJIPYa1w69hFCXpP6sA6dg61XTks5uq_TNgaJpZM4YLKUC .

-- Sincerely yours & Best regard!

- Mr.Johan Hu - Mobile: 13510935999 E-mail / MSN : johan@ryron.net skype: iRyron


Website http://www.ryron.net/ | Quality Terms http://www.ryron.net/about/policies.html | About http://www.ryron.net/about.html RYRON ELECTRONICS LIMITED Addr:20#, East Block,GuangYe Bldg,Fuhua Rd.,Futian District, 518000 Tel: (86) 0755-83978411 Fax: (86) 0755-83974211

googlebot commented 5 years ago

CLAs look good, thanks!