PolymerElements / iron-form

Custom form element
https://www.webcomponents.org/element/PolymerElements/iron-form
63 stars 81 forks source link

Fixed chrome non-unique id error #287

Open itzzshirlayyy opened 6 years ago

itzzshirlayyy commented 6 years ago

Fixes issue https://github.com/PolymerElements/iron-form/issues/288

Removed id #helper from iron-form and created the class variable .helper

This ensures no duplicate 'non-unique id' error that chrome console checks for (pic below) screen shot 2018-09-06 at 11 46 40 am

This issue can be replicated when you are using different components which internally uses iron-form.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
itzzshirlayyy commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

I signed it!