PolymerElements / iron-icon

Element that displays a single icon
https://webcomponents.org/element/PolymerElements/iron-icon
40 stars 39 forks source link

Fix for #8. Added alternative text option. No alt or empty alt adds a… #101

Open erikkroes opened 7 years ago

erikkroes commented 7 years ago

…ria-hidden. Alt adds aria-label and role.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


erikkroes commented 7 years ago

I signed it!

googlebot commented 7 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

erikkroes commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!