Move <template> to _template

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

Punk-UnDeaD commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!

notwaldorf commented 6 years ago

Closing this, as this is a non-standard way to write an element. What is this PR trying to fix?

Punk-UnDeaD commented 6 years ago

If this is done and application builded to one js file, firefox has badass improve performance

Punk-UnDeaD commented 6 years ago

Do you hate Firefox users and web-depelopers so much that you think that they should suffer for the sake of the standart?

notwaldorf commented 6 years ago

I've already answered and closed this in #113. Please see that thread for the complete answer

Punk-UnDeaD commented 6 years ago

Saving the template as a string this way has absolutely no performance implications, despite what you might think. From the string, you still have to construct the DOM if you want to stamp it, which Polymer automatically does (when it fetches the template from the <template> tag)

building app to one js and link it as script without defered parsing improve performance in firefox from zero to infynity for this we need move all templates for all components to script, build it and extract pure js pls, beleave me or try it

do you want work on performance or hate firefox users?

dfreedm commented 6 years ago

I'd really like to see some citations for "improve performance in firefox from zero to infynity". However, what you've done so far is break the 1.x tests because _template does not support strings in Polymer 1.

Until such time as you can clearly show a performance benefit without breaking the tests, we cannot accept this pull request, nor any similar ones.

Punk-UnDeaD commented 6 years ago

https://github.com/Punk-UnDeaD/polypoly pls, check examples from this repo I use paper-progress, but I can add iron-icon too vanilla folder has polymer components builded by polymer build patched folder has patched component builded as js pls open index-compressed.html from both folder in firefox and you can see difference without stopwatch

PolymerElements / iron-icon

Move <template> to _template #115