search

PolymerElements / iron-icons

A set of icons for use with iron-icon
https://www.webcomponents.org/element/PolymerElements/iron-icons
105 stars 61 forks source link

new material design icons #45

Closed notwaldorf closed 8 years ago

notwaldorf commented 8 years ago

Fixes https://github.com/PolymerElements/iron-icons/issues/41

Material Design Icons has a whole bunch of new icons. These are them. It looks like the things that have xlink:href has been removed, but I don't know if this constitutes as a fix (they didn't work) or a breaking change (because they've been removed). In any case, this is what happens when you run the script.

@cdata @azakus @ebidel

ebidel commented 8 years ago

LGTM. IMO it's not breaking if the icons never worked in the first place. No one was using them :)

ebidel commented 8 years ago

Would we mind landing and tagging a new release? I need the fixed up and new icons for a new tool :open_mouth:

notwaldorf commented 8 years ago

Ping @cdata for a review :)

ebidel commented 8 years ago

Mergy mergy!? This fixes a few outstanding issues.

dfreedm commented 8 years ago

LGTM with nits

notwaldorf commented 8 years ago

@azakus I just ran the script and this is what it output. Should I manually fix these, even though they'll get overwritten next time the script is ran?

dfreedm commented 8 years ago

@notwaldorf Ugh, those probably need to be fixed in the source of material icons.

ebidel commented 8 years ago

Can we add this as part of our tool? Some of the icons have been broken in the current release for a while. I'm worried waiting on upstream will take even longer.

dfreedm commented 8 years ago

@ebidel @notwaldorf fixed the fill attributes, PTAL

ebidel commented 8 years ago

LGTM