search

PolymerElements / iron-icons

A set of icons for use with iron-icon
https://www.webcomponents.org/element/PolymerElements/iron-icons
105 stars 61 forks source link

2.0-preview branch #64

Closed bicknellr closed 7 years ago

googlebot commented 7 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

bicknellr commented 7 years ago

I'm deleting a bunch of @rjk40's comments: screen shot 2017-03-01 at 15 03 16 screen shot 2017-03-01 at 15 03 35

bicknellr commented 7 years ago

Still trying to figure out a minimal repro for this styling issue in the demo.

bicknellr commented 7 years ago

Submitted as https://github.com/Polymer/polymer/issues/4521.

bicknellr commented 7 years ago

Polymer/polymer#4521 is fixed; I'll try reverting the demo changes again.

bicknellr commented 7 years ago

Oh, there's not a release yet, the fix is still only available in master.

bicknellr commented 7 years ago

Updating your local copy of Polymer to master makes the demo work but there's no release, so it won't work with just polymer install --variants yet. :(

(edit: weird grammar)

notwaldorf commented 7 years ago

@bicknellr one small nit left. gonna keep this red though until we can verify it works with the next rc release (hopefully tomorrow)

bicknellr commented 7 years ago

@notwaldorf, 2.0.0-rc.4 is out with the custom-style fix.