PolymerElements / iron-icons

A set of icons for use with iron-icon
https://www.webcomponents.org/element/PolymerElements/iron-icons
105 stars 61 forks source link

Fixes #56 by updating material icons to 3.0.1 release #65

Closed bennypowers closed 8 years ago

bennypowers commented 8 years ago

Steps I took:


# Fork
git clone git@github.com:bennyp123/iron-icons
cd iron-icons
sh ./update-icons.sh
git commit -am "Fixes #56 by updating material icons to 3.0.1 release"
git push -u origin master
# Submit PR
bennypowers commented 8 years ago

update-icons.sh:27-36

header() {
cat > $1 <<ENDL
<!--
Copyright (c) 2014 The Polymer Project Authors. All rights reserved.
This code may only be used under the BSD style license found at http://polymer.github.io/LICENSE.txt
The complete set of authors may be found at http://polymer.github.io/AUTHORS.txt
The complete set of contributors may be found at http://polymer.github.io/CONTRIBUTORS.txt
Code distributed by Google as part of the polymer project is also
subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
-->

should i replace the @license line?

bennypowers commented 8 years ago

https://github.com/PolymerElements/iron-icons/pull/65/commits/551f1c44c20df1d4299f04825b4aba0920701c48 replaces @license string

notwaldorf commented 8 years ago

@bennyp123 Hiya! Just merged the license string into master -- would you mind rebasing and regenerating the files, please?

bennypowers commented 8 years ago

sorry for the mess. had a file in the working dir that didn't belong when i rebased and commit. everything should be kosher now

notwaldorf commented 8 years ago

Hmm I'm not sure the rebase worked -- it looks like it's trying to make changes to update-icons.sh (which are on master) :(

bennypowers commented 8 years ago

I'm closing this and making a new PR.

notwaldorf commented 8 years ago

ha. sorry!