Use viewBox attribute over size defined on iconset

PolymerElements / iron-iconset-svg

Represents a source of icons expressed as a collection of inline SVGs

https://www.webcomponents.org/element/PolymerElements/iron-iconset-svg

37 stars 34 forks source link

Use viewBox attribute over size defined on iconset #13

Closed jennvoss closed 8 years ago

jennvoss commented 9 years ago

If a viewBox attribute exists on the source svg element then use it, otherwise fall back to the size defined on the iconset.

This allows icons to be shapes other than square, and allows each icon within a given set to define it's own viewBox size.

When the viewBox attribute is used, sizing/scaling icons relative to one another is the responsibility of the user.

googlebot commented 9 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

jennvoss commented 9 years ago

I signed it!

On Tue, Jun 9, 2015 at 3:27 PM, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

[image: :memo:] Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.

If you signed the CLA as a corporation, please let us know the company's name.

— Reply to this email directly or view it on GitHub https://github.com/PolymerElements/iron-iconset-svg/pull/13#issuecomment-110475494 .

googlebot commented 9 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot commented 9 years ago

CLAs look good, thanks!

notwaldorf commented 9 years ago

This should fix https://github.com/PolymerElements/iron-iconset-svg/issues/3

cdata commented 8 years ago

Thanks for the contribution, sorry for the long wait!