search

PolymerElements / iron-iconset-svg

Represents a source of icons expressed as a collection of inline SVGs
https://www.webcomponents.org/element/PolymerElements/iron-iconset-svg
37 stars 34 forks source link

Fix icon removal when using shady DOM #44

Closed alberthier closed 7 years ago

alberthier commented 8 years ago

When clearing the icon from an iron-icon element, the local dom isn't cleared properly on browsers not supporting shadow DOM natively (Safari, Edge, IE).

This is due to the fact that removeIcon doesn't try to access to the element's local DOM root whereas applyIcon does.

This PR makes both method behave the same way

freshp86 commented 7 years ago

Any status updates about this PR? It also fixes https://github.com/PolymerElements/iron-icon/issues/67. BTW in my case removeIcon() does not work even though ShadowDOM is used.

danbeam commented 7 years ago

/cc @azakus (maintainer) @kevinpschaaf (tl) @tjsavage (pm)

even though this PR is titled "when using shady DOM", @freshp86 locally patched Chrome's fork of Polymer and this fixed some issues for us.

danbeam commented 7 years ago

related downstream issue: https://github.com/PolymerElements/iron-icon/issues/67 chrome-side bug: https://crbug.com/628071

freshp86 commented 7 years ago

@azakus: Any status update? When can we expect this PR to be merged?

danbeam commented 7 years ago

@tjsavage