Closed dlockhart closed 6 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
CLAs look good, thanks!
Hello, what is the state of this merge request?
:+1:
Hey, @notwaldorf just pointed out to me that you (or someone else watching this thread) might need this in 1.x, as the PR is from quite a while ago. If so, feel free to open a copy of this PR with 1.x
as the base branch and I'll merge it there as well.
@bicknellr & @notwaldorf thanks for thinking about that! Not needed, as I've got a workaround in place inside one of our components that I'll keep around in the Polymer 1.x version of that component and remove when we make the jump to 2.x. Thanks though!
Hey @bicknellr, thanks for fixing this issue. I created a pull request for the 1.x branch, please merge it as well: https://github.com/PolymerElements/iron-iconset-svg/pull/73
This fixes #46 by setting the
focusable
attribute on the SVG tofalse
, which prevents SVG elements from receiving tab focus as the user tabs around the page in IE and Edge.Information on the
focusable
attribute from the SVG W3C spec: https://www.w3.org/TR/SVGTiny12/interact.html#focusable-attrStack Overflow discussion of this fix: http://stackoverflow.com/questions/18646111/disable-onfocus-event-for-svg-element