PolymerElements / iron-iconset-svg

Represents a source of icons expressed as a collection of inline SVGs
https://www.webcomponents.org/element/PolymerElements/iron-iconset-svg
37 stars 33 forks source link

Add global-only RTL mirroring. #74

Closed cdata closed 7 years ago

cdata commented 7 years ago

RTL detection based on CSS styles in subtrees has timing issues. In some circumstances, the value of the direction style property will be empty string while an element is booting up even though it should probably read as "rtl".

This change proposes a fix where an addition configuration (use-global-rtl-attribute) of the iconset tells it to use the value of the dir attribute on either <body> or <html>, whichever is available.

Fixes #64

bicknellr commented 7 years ago

Is this considered solving #57?