search

PolymerElements / iron-iconset-svg

Represents a source of icons expressed as a collection of inline SVGs
https://www.webcomponents.org/element/PolymerElements/iron-iconset-svg
37 stars 34 forks source link

Setting the transform-origin to resolve shadow RTL mirroring #81

Closed dlockhart closed 6 years ago

dlockhart commented 6 years ago

This fixes #80 and an issue with icons in RTL being mirrored around the incorrect origin on browsers which support native shadow DOM.

(sample code in #80)

Before: iconset-rtl

After: iconset-rtl-fixed

bicknellr commented 6 years ago

I think we should set transform-origin directly to the value we want in this case: center.

dlockhart commented 6 years ago

Agreed, I've updated the code.

bicknellr commented 6 years ago

I'm running this through tests at the moment. It'll probably be later tonight by the time results are in so I'll post an update tomorrow.

bicknellr commented 6 years ago

http://go/polymerelements_iron-iconset-svg_pull_81 All the tests there are the same as others that failed in the same run, so I'm going to call this ok.