PolymerElements / iron-image

Image element with sizing and preloading options
https://www.webcomponents.org/element/PolymerElements/iron-image
37 stars 43 forks source link

Placeholder didn't hide if `src` was not encoded #120

Closed vedtam closed 1 year ago

vedtam commented 7 years ago

Images URIs fed into iron-image not being properly encoded fail this check:

if (this.$.img.src !== this._resolveSrc(this.src)) {
          return;
 }

because this.$.img.src gets automatically encoded but this.src not. encodeURI(testSrc) fixed the issue for me.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


vedtam commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!