search

PolymerElements / iron-image

Image element with sizing and preloading options
https://www.webcomponents.org/element/PolymerElements/iron-image
37 stars 43 forks source link

docs: iron-image position property should define valid values #98

Open Splaktar opened 7 years ago

Splaktar commented 7 years ago

Description

The docs for iron-image's position property define a default value of center but they don't define what other values are valid.

Relevant code: https://github.com/PolymerElements/iron-image/blob/d0699b5adf7a60d5d294c07d8765e3a3c5781b8c/iron-image.html#L178

Expected outcome

Similar to the docs for iron-image's sizing property it should list the valid values.

Actual outcome

center appears to be the only valid value of this property. Searching the code and repository doesn't turn up anything helpful.

Live Demo

https://elements.polymer-project.org/elements/iron-image#property-position

davidmaxwaterman commented 6 years ago

+1 this sort of thing is quite irritating

davidmaxwaterman commented 6 years ago

For the record, it seems to be a background-position:

https://developer.mozilla.org/en-US/docs/Web/CSS/background-position