PolymerElements / iron-input

An input with data binding
https://webcomponents.org/element/PolymerElements/iron-input
33 stars 45 forks source link

issue with invalid property not setted correctly if type is email aft… #30

Closed ghost closed 9 years ago

ghost commented 9 years ago

…er error

if i have an element like: <input id="test-invalid" type="email" is="iron-input" invalid="{{invalid}}" /> and i type a wrong email the invalid property is false as expected. Then if i clear the field then call validate method, the result is true and the invalid property remain true.

googlebot commented 9 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


ghost commented 9 years ago

I signed it!

2015-06-01 0:46 GMT+02:00 googlebot notifications@github.com:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

[image: :memo:] Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

— Reply to this email directly or view it on GitHub https://github.com/PolymerElements/iron-input/pull/30#issuecomment-107254740 .

googlebot commented 9 years ago

CLAs look good, thanks!

notwaldorf commented 9 years ago

Good catch! Thanks for the contribution!

Would you mind squashing your commits before I merge this, please? Thanks!

ghost commented 9 years ago

i have squashed my commits.

notwaldorf commented 9 years ago

Blerg. Something changed under you, I'm afraid, and you need to rebase :(

ghost commented 9 years ago

ok i have rebased the branch.

notwaldorf commented 9 years ago

Thanks! :gem: