apply validation in the correct order

notwaldorf commented 8 years ago

Fixes https://github.com/PolymerElements/iron-input/issues/46

The issue was that if you type invalid things (like ---) in type="number, the browser sets the value to "". Since we were first checking required and the value, we actually returned true in this case.

I've rejiggered the function to:

first check what the browser thinks
if the browser thinks this is ok, then do the required check, and ask the validator if we have one.

It used to be that the validator was checked first. First of all, I'm not sure what it means to have both a validator and a browser validation. Take something like <input pattern="[1-9]*" validator="value-is-exactly-equal-to-cat">; should the string "cat" be valid? not be valid? who knows. Second, I am not even sure that's right, since inside a form, for example, the form will only look at the browser validity anyway and ignore the validator, so technically browser rules all. I am not opposed to leaving it the original way though.

Here's the kicker: I literally cannot add a test for this. Because security, you can't simulate typing inside and input, and because type=number is 🍌🍌🍌 , it does not let you programmatically set it to an invalid value. 😂🔫