search

PolymerElements / iron-input

An input with data binding
https://webcomponents.org/element/PolymerElements/iron-input
33 stars 45 forks source link

Update documentation for properties #78

Closed dsschnau closed 8 years ago

dsschnau commented 8 years ago

preventInvalidInput and allowedPattern. Clarify that the regex on allowedPattern checks against individual characters and not the input's value as a whole. Closes issue #77.

dsschnau commented 8 years ago

Just realized I had made a PR for my own fork >.<

cc @notwaldorf for review

dsschnau commented 8 years ago

@notwaldorf I made the changes bases on your feedback. Hopefully this can help prevent confusion in the future for someone.

notwaldorf commented 8 years ago

This is perfect! Would you mind squashing your commits so I can merge this? Thanks so much!

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

notwaldorf commented 8 years ago

(I think you also need a rebase along with the squash)

dsschnau commented 8 years ago

Thanks, I realized because I committed straight to master it got to be a mess. I'm going to close this PR and submit a new one (sorry.. still kind of a git noob)

dsschnau commented 8 years ago

I submitted a (hopefully) cleaner PR #80