PolymerElements / iron-input

An input with data binding
https://webcomponents.org/element/PolymerElements/iron-input
33 stars 45 forks source link

announce when invalid characters are blocked #82

Closed notwaldorf closed 8 years ago

notwaldorf commented 8 years ago

Fixes https://github.com/PolymerElements/iron-input/issues/57.

We announce two messages:

valdrinkoshi commented 8 years ago

Alright, tested on Android talkback: Invalid string of characters not entered gets repeated 4 times. In IE-Edge the text doesn't get announced, in IE11 all looks good ie-a11y

notwaldorf commented 8 years ago

@valdrinkoshi Does anything get announced in Edge? Like, say, paper-toast? These all sound like potential announcer bugs :(

valdrinkoshi commented 8 years ago

No, in fact i just opened an issue here https://github.com/PolymerElements/iron-a11y-announcer/issues/16 I'm checking if the multi-time announce is also a problem of the announcer

valdrinkoshi commented 8 years ago

Yep, also the multi-time announce is a problem of iron-a11y-announcer https://github.com/PolymerElements/iron-a11y-announcer/issues/17

This PR LGTM :+1:

notwaldorf commented 8 years ago

Sweet, thanks!