PolymerElements / iron-input

An input with data binding
https://webcomponents.org/element/PolymerElements/iron-input
33 stars 45 forks source link

Loop in 2.0-preview port #92

Closed dam0vm3nt closed 7 years ago

dam0vm3nt commented 8 years ago

When using iron-input (2.0-preview) branch a stack overflow exception is thrown during initialization :

...
_bindValueChanged   @   iron-input.html:275
runMethodEffect @   property-effects.html:390
runMultiObserverEffect  @   property-effects.html:86
runEffectsForProperty   @   batched-effects.html:133
runEffects  @   batched-effects.html:115
_propertiesChanged  @   batched-effects.html:177
_flushProperties    @   property-accessors.html:112
_flushProperties    @   property-effects.html:716
clients.forEach @   batched-effects.html:238
_flushClients   @   batched-effects.html:235
_propertiesChanged  @   batched-effects.html:172
_flushProperties    @   property-accessors.html:112
_flushProperties    @   property-effects.html:716
_invalidateProperties   @   property-effects.html:705
_setProperty    @   property-accessors.html:75
set @   property-effects.html:857
_setPropertyFromNotification    @   property-effects.html:864
_setPropertyFromNotification    @   batched-effects.html:207
handleNotification  @   property-effects.html:351
(anonymous function)    @   property-effects.html:336
i   @   event-mixin.js:245
fire    @   legacy-element.html:210
_bindValueChanged   @   iron-input.html:275
runMethodEffect @   property-effects.html:390
runMultiObserverEffect  @   property-effects.html:86
runEffectsForProperty   @   batched-effects.html:133
runEffects  @   batched-effects.html:115
_propertiesChanged  @   batched-effects.html:177
_flushProperties    @   property-accessors.html:112
_flushProperties    @   property-effects.html:716
clients.forEach @   batched-effects.html:238
_flushClients   @   batched-effects.html:235
_propertiesChanged  @   batched-effects.html:172
_flushProperties    @   property-accessors.html:112
_flushProperties    @   property-effects.html:716
_invalidateProperties   @   property-effects.html:705
_setProperty    @   property-accessors.html:75
set @   property-effects.html:857
_setPropertyFromNotification    @   property-effects.html:864
_setPropertyFromNotification    @   batched-effects.html:207
handleNotification  @   property-effects.html:351
(anonymous function)    @   property-effects.html:336
i   @   event-mixin.js:245
fire    @   legacy-element.html:210
_bindValueChanged   @   iron-input.html:275
notwaldorf commented 8 years ago

Oof this looks new

notwaldorf commented 8 years ago

Hmm, the demo looks fine for me, on Chrome stable and Canary. Do you have the latest Polymer 2.0 version? Any more info about what you're doing (a JSBin with repro steps would be ideal)

dam0vm3nt commented 8 years ago

polymer version should be ok, but bower gives me conflicts when using other 2.0 elements so I suspect there something weird going on. I'll investigate itand try to repro it

dam0vm3nt commented 8 years ago

Here's a jsFiddle with a repro : https://jsfiddle.net/2hbyj94k/11/

The problem arises when setting null the prop in the constructor.