search

PolymerElements / iron-location

A Polymer element that manages binding to the page's URL.
22 stars 41 forks source link

Capture links that point to the current page. #44

Closed rictic closed 8 years ago

rictic commented 8 years ago

For links that point to the current href we want to do absolutely nothing. No navigation, no full page refresh, no new history entry.

Fixes #43

e111077 commented 8 years ago

Sorry I've been away from app-route and family, but where did we land on the issue of trailing slashes? Does https://www.google.com the same as https://www.google.com/? If so, then we should do some handling of that in this PR, if not LGTM

rictic commented 8 years ago

_getSameOriginLinkHref will normalize https://www.google.com to https://www.google.com/ but it won't normalize https://www.google.com/foo to https://www.google.com/foo/. I think this behavior is correct, as the first two are actually equivalent and the latter two are distinct.

e111077 commented 8 years ago

This is perfect then. LGTM :+1: great job!

rictic commented 8 years ago

Thanks for the review!