PolymerElements / iron-location

A Polymer element that manages binding to the page's URL.
22 stars 41 forks source link

prevents infinite loop with ' #61

Closed e111077 closed 7 years ago

e111077 commented 7 years ago

fixes PolymerElements/app-route#162 and PolymerElements/app-route#157. Required for PolymerElements/app-route#163

When ' is put in the window.location, the browser automatically sets it to %27 which causes a discrepancy with paramsString and the window.location's query params. This results in an infinite loop when iron-query-params is properly linked up to iron-location. (see PolymerElements/app-route#162 and PolymerElements/app-route#157)

keanulee commented 7 years ago

LGTM. @cdata Can you take a quick look at this (it's small!) and give a 👍 ? Thanks!

cdata commented 7 years ago

LGTM 👍